Skip to content

MNT Move kmeans_plusplus next to _kmeans_plusplus #19666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2021
Merged

MNT Move kmeans_plusplus next to _kmeans_plusplus #19666

merged 1 commit into from
Mar 12, 2021

Conversation

jeremiedbb
Copy link
Member

Missed that during review of #17937.

ogrisel
ogrisel approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.

@ogrisel
Copy link
Member

ogrisel commented Mar 12, 2021

Let's wait for CI, just in case, and I'll merge.

@ogrisel ogrisel merged commit 579e7de into scikit-learn:main Mar 12, 2021
marrodion pushed a commit to marrodion/scikit-learn that referenced this pull request Mar 17, 2021
@jeremiedbb @marrodion
move kmpp public next to kmpp private (scikit-learn#19666)
6664bd6
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiedbb @ogrisel