Skip to content

Removed assert_warns_message from gaussian_process/tests #19697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2021
Merged

Removed assert_warns_message from gaussian_process/tests #19697

merged 3 commits into from
Mar 19, 2021

Conversation

avigupta2612
Copy link
Contributor

Reference Issues/PRs

Part of #19414 for gaussian_process/tests

What does this implement/fix? Explain your changes.

Removed assert_warns_message from tests_gpr.py and tests_gpc.py

Any other comments?

jeremiedbb
jeremiedbb approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @avigupta2612

@avigupta2612
Copy link
Contributor Author

guassian_process/tests is still using asserts_raise_message which was removed in #14216 . So should I remove those and open a PR in that issue?

@jeremiedbb
Copy link
Member

jeremiedbb commented Mar 17, 2021 •
edited
Loading

So should I remove those

Sure ! I think it's fine to do it in this PR since it's just one occurence but feel free to open a new PR if you prefer.
(there's also an occurence in test_kernels)

avigupta2612
avigupta2612 commented Mar 18, 2021
View reviewed changes
ogrisel
ogrisel approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ogrisel ogrisel merged commit 071ddc7 into scikit-learn:main Mar 19, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:gaussian_process No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avigupta2612 @jeremiedbb @ogrisel