Replaced assert_raises from utils/tests/test_estimator_checks #19709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Mar 18, 2021
There was a problem hiding this comment.
Thank you for the PR @avigupta2612 !
This is the one file we can not use pytest in, because we run build_tools/azure/test_pytest_soft_dependency.sh on it to make sure estimator_checks works without pytest.
I think it would be good to add a comment to the top of this file that explains why this file does not use pytest.
|
Ok, so I should revert back the changes and add the comment on the top. |
ogrisel
approved these changes
Mar 19, 2021
|
Thanks! |
|
While we can't use pytest, we can use the internal @avigupta2612 would you like to submit a PR for this? |
|
@NicolasHug Yes, I will work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of #14216 for
utils/tests/test_estimator_checks.pyWhat does this implement/fix? Explain your changes.
Replaced use of assert_raises and assert_raises_regex with pytest.raises in
utils/tests/test_estimator_checks.pyAny other comments?