Skip to content

MNT Remove HistGradientBoosting from experimental #19799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 2, 2021
Merged

MNT Remove HistGradientBoosting from experimental #19799

merged 17 commits into from
Apr 2, 2021

Conversation

NicolasHug
Copy link
Member

Closes #19792

The last obstacle to make these estimators stable was #18894. The preferred solution has not ETA yet and should be backward compatible anyway, so it's not worth delaying the "stabilization" of the estimators any longer.

importing enable_hist_gradient_boosting now throws a warning - no strong opinion, but it's probably better to encourage users to remove the imports, hence the warning.

for ref:

(sklearn-dev) ➜  scikit-learn git:(exp_gbdt) ✗ git grep enable_hist
doc/modules/classes.rst:   experimental.enable_hist_gradient_boosting
doc/whats_new/v0.21.rst:  need to explicitly import ``enable_hist_gradient_boosting``::
doc/whats_new/v0.21.rst:    >>> from sklearn.experimental import enable_hist_gradient_boosting  # noqa
doc/whats_new/v0.21.rst:  enable_hist_gradient_boosting`.
sklearn/experimental/enable_hist_gradient_boosting.py:    "it is not needed to import enable_hist_gradient_boosting anymore. "
sklearn/experimental/tests/test_enable_hist_gradient_boosting.py:        from sklearn.experimental import enable_hist_gradient_boosting

jeremiedbb
jeremiedbb reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @NicolasHug for this tedious search and replace :)

@NicolasHug @jeremiedbb
Update doc/developers/maintainer.rst
81a8bcc 
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
jeremiedbb
jeremiedbb reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a solution to the doc build failure, but I'm not familiar with sphinx so it might not be that at all :)

jeremiedbb
jeremiedbb approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @NicolasHug !

lorentzenchr
lorentzenchr reviewed Apr 2, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick + question of backward compatibility.

lorentzenchr
lorentzenchr approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @NicolasHug Thank you. Finally, HGBT becomes stable. I hope that this helps to get more widely used.

@lorentzenchr lorentzenchr changed the title [MRG] MNT Remove HistGradientBoosting from experimental MNT Remove HistGradientBoosting from experimental Apr 2, 2021
@lorentzenchr lorentzenchr merged commit 309f135 into scikit-learn:main Apr 2, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
@lorentzenchr lorentzenchr mentioned this pull request Apr 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentzenchr lorentzenchr lorentzenchr approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove HistGradientBoosting from the experimental features...
3 participants
@NicolasHug @lorentzenchr @jeremiedbb