CI Fix string comparison in check milestone workflow #19840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This did not trigger when I added a milestone. |
|
I do not think there is a trigger for "adding a milestone" |
That's my problem... :) you can add a label if you only need to test |
|
I did not notice this in my first review, this means a maintainer must add a milestone and then add a label to trigger the workflow. (In that order) If there isn't a proper label to add, then we need to add and remove a label to trigger the check milestone workflow. I'll merge to fix the bug, but I am very uncertain about this milestone check. |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up of #19833. Thanks @NicolasHug for noticing.
The variable in the comparison was no longer a string.
Cc @thomasjpfan