Skip to content

FIX Removes unecessary check in _BaseChain #19865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

FIX Removes unecessary check in _BaseChain #19865

merged 1 commit into from
Apr 12, 2021

Conversation

glemaitre
Copy link
Member

closes #19857

Remove double check on X in _BaseChain.

thomasjpfan
thomasjpfan approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title FIX remove unecessary check in _BaseChain FIX Removes unecessary check in _BaseChain Apr 12, 2021
@thomasjpfan thomasjpfan merged commit e56d76a into scikit-learn:main Apr 12, 2021
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Apr 19, 2021
@glemaitre @thomasjpfan
FIX Removes unecessary check in _BaseChain (scikit-learn#19865)
d674bda
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_BaseChain is validating data twice
2 participants
@glemaitre @thomasjpfan