FIX add support for multilabel classification in RidgeClassifier* #19869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Apr 12, 2021
|
@agramfort Do you have an idea of a good test to check that the classification is going well in But maybe there is something better to be tested. |
2 tasks
|
OK this is ready for a review. Maybe @agramfort if you can have a look at this one. |
agramfort
approved these changes
Aug 7, 2021
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
agramfort
approved these changes
Aug 7, 2021
There was a problem hiding this comment.
I’ll let @lorentzenchr or @rth do the second review. Thx @glemaitre
rth
reviewed
Oct 14, 2021
|
I address the comment @rth |
jeremiedbb
reviewed
Oct 27, 2021
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…ikit-learn#19869) Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…ikit-learn#19869) Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
added a commit
that referenced
this pull request
Dec 25, 2021
…9869) Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19858
closes #19882
build on the top of #19859
This PR fixes the
predictmethod inRidgeClassifierCVand enables support forRidgeClassifierwhen the target is a multilabel indicator matrix.The common tests are using #19859. The change in this PR should be limited to
ridge.pyandtest_ridge.pyonce #19859 is merged.