MNT Use const memory views in DistanceMetric subclasses #19883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Const fused types has not been released yet. But in this case, |
const with fused types memory views for cluster.DistanceMetricsconst memory views for cluster.DistanceMetrics
ogrisel
reviewed
Apr 14, 2021
There was a problem hiding this comment.
+1 for fixing #19875 explicitly as part of this PR with a dedicated non-regression test + an entry in the changelog.
Since the DistanceMetric class is part of the documented public API, we should also mention the fix for this class in the changelog.
Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>
ogrisel
approved these changes
Apr 14, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Fix finting, again.
I was inspecting if changes made to |
const memory views for cluster.DistanceMetricsconst memory views for neighbors.DistanceMetric subclasses
thomasjpfan
reviewed
Apr 14, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
const memory views for neighbors.DistanceMetric subclasses
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
…#19883) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19875.
See also #10624.
What does this implement/fix? Explain your changes.
Distances computations (
cluster.DistanceMetrics) implemented in Cython do not support readonly datasets, which are obtained when using mem-mapping for instance. This makes some interfaces relying on those implementation fail (see #19875).This PR makes the Cython implementations use
constmemoryviews to be able computing those distances on memmapped datasets.Any other comments?
5b61a29 fixes #19875, but maybe we should have the downstream issues be solved independently from this PR.
Also
scipy.spatial.distance.{cdist,pdist}on memmapped datasets with'mahalanobis'as a metric fail.I am inspecting why; in the meantime 716b330 skips the associated tests.