Skip to content

FIX OneHotEncoder.fit no longer alters the drop parameter #19924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2021
Merged

FIX OneHotEncoder.fit no longer alters the drop parameter #19924

merged 4 commits into from
Apr 20, 2021

Conversation

thomasjpfan
Copy link
Member

This PR adjusts OneHotEncoder.fit so it does not change self.drop during fit.

@thomasjpfan thomasjpfan changed the title FIX Do not set self.drop in OneHotEncoder.fit FIX OneHotEncoder.fit no longer alters the drop parameter Apr 19, 2021
lorentzenchr
lorentzenchr approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lorentzenchr
Copy link
Member

Something for milestone v0.24.2?

@glemaitre
Copy link
Member

Could you move the entry for 0.24.2

@glemaitre glemaitre added this to the 0.24.2 milestone Apr 20, 2021
glemaitre
glemaitre approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit 004b44d into scikit-learn:main Apr 20, 2021
@glemaitre
Copy link
Member

Thanks @thomasjpfan

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@thomasjpfan @glemaitre
FIX OneHotEncoder.fit no longer alters the drop parameter (scikit-lea…
43b444e 
…rn#19924)
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@thomasjpfan @glemaitre
FIX OneHotEncoder.fit no longer alters the drop parameter (#19924)
6f666d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@glemaitre glemaitre glemaitre approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @lorentzenchr @glemaitre @jnothman