Skip to content

CI Fixes MAC ar build error #19968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Fixes #19963

What does this implement/fix? Explain your changes.

Uses /usr/bin/ar instead of llvm-ar.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for investigating.

@ogrisel
Copy link
Member

ogrisel commented Apr 26, 2021

Does it mean we need to update the build docs accordingly?

@jeremiedbb
Copy link
Member

Does it mean we need to update the build docs accordingly?

Our doc only explains how to build with openmp support enabled. I think we should not care to much about how to build without openmp

@ogrisel ogrisel merged commit ff09499 into scikit-learn:main Apr 26, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 27, 2021
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI issue with clang on MacOS
3 participants