Skip to content

CI Uses minimum version for doc-min-dependencies #20057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ jobs:
- SCIKIT_IMAGE_VERSION: 'min'
- SPHINX_VERSION: 'min'
- PANDAS_VERSION: 'min'
- SPHINX_GALLERY_VERSION: 'min'
- NUMPYDOC_VERSION: 'min'
- SPHINX_PROMPT_VERSION: 'min'
steps:
- checkout
- run: ./build_tools/circle/checkout_merge_commit.sh
Expand Down Expand Up @@ -57,6 +60,9 @@ jobs:
- SCIKIT_IMAGE_VERSION: 'latest'
- SPHINX_VERSION: 'min'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to use latest here to see and launch a doc build to see if it would break?

- PANDAS_VERSION: 'latest'
- SPHINX_GALLERY_VERSION: 'latest'
- NUMPYDOC_VERSION: 'latest'
- SPHINX_PROMPT_VERSION: 'latest'
steps:
- checkout
- run: ./build_tools/circle/checkout_merge_commit.sh
Expand Down
6 changes: 3 additions & 3 deletions build_tools/circle/build_doc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ conda create -n $CONDA_ENV_NAME --yes --quiet \
joblib memory_profiler packaging seaborn pillow pytest coverage

source activate testenv
pip install sphinx-gallery
pip install numpydoc
pip install sphinx-prompt
pip install "$(get_dep sphinx-gallery $SPHINX_GALLERY_VERSION)"
pip install "$(get_dep numpydoc $NUMPYDOC_VERSION)"
pip install "$(get_dep sphinx-prompt $SPHINX_PROMPT_VERSION)"

# Set parallelism to 3 to overlap IO bound tasks with CPU bound tasks on CI
# workers with 2 cores when building the compiled extensions of scikit-learn.
Expand Down