Skip to content

DOC correct behavior of needs_threshold in make_score #20079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2021
Merged

DOC correct behavior of needs_threshold in make_score #20079

merged 2 commits into from
May 13, 2021

Conversation

ZeyuSun
Copy link
Contributor

@ZeyuSun ZeyuSun commented May 11, 2021

Reference Issues/PRs

Fixes #20073.
See also #10247 (comment) and PR #14358

What does this implement/fix? Explain your changes.

Correct the description of the behavior of needs_threshold=True in make_score.

Any other comments?

@thomasjpfan thomasjpfan changed the title correct behavior of needs_threshold in make_score DOC correct behavior of needs_threshold in make_score May 11, 2021
thomasjpfan
thomasjpfan reviewed May 11, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ZeyuSun !

@ZeyuSun @thomasjpfan
Update sklearn/metrics/_scorer.py
373cee9 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
NicolasHug
NicolasHug approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZeyuSun

thomasjpfan
thomasjpfan approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 48ab1bf into scikit-learn:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:metrics No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make_scorer notes is incorrect about the behavior of needs_threshold
3 participants
@ZeyuSun @NicolasHug @thomasjpfan