Skip to content

[CI] Fix min dependencies for scikit-image. #20108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 19, 2021
Merged

[CI] Fix min dependencies for scikit-image. #20108

merged 7 commits into from
May 19, 2021

Conversation

cmarmo
Copy link
Contributor

@cmarmo cmarmo commented May 18, 2021

Reference Issues/PRs

Follow up of #20069

What does this implement/fix? Explain your changes.

Fix the minimal version of dask to make minimal version of scikit-image work

Any other comments?

ping @GaelVaroquaux

@cmarmo cmarmo changed the title [ci build] Fix min dependencies for dask. [CI] Fix min dependencies for dask. May 18, 2021
@cmarmo
Copy link
Contributor Author

cmarmo commented May 18, 2021

All green! 🚀

jjerphan
jjerphan approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cmarmo!

@glemaitre
Copy link
Member

arfff conda has only scikit-image=0.14.2 available for Python 3.7. We can check if the lazy import was backported in this version.

@cmarmo
Copy link
Contributor Author

cmarmo commented May 19, 2021

arfff conda has only scikit-image=0.14.2 available for Python 3.7. We can check if the lazy import was backported in this version.

Or install via pip...

@cmarmo
Copy link
Contributor Author

cmarmo commented May 19, 2021

All green... :)

@cmarmo cmarmo changed the title [CI] Fix min dependencies for dask. [CI] Fix min dependencies for scikit-image. May 19, 2021
glemaitre
glemaitre approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit 2a43ed2 into scikit-learn:main May 19, 2021
@cmarmo cmarmo deleted the doc-min-dep-fix branch May 19, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmarmo @glemaitre @jjerphan