-
-
Notifications
You must be signed in to change notification settings - Fork 26k
ENH ColumnTransformer.transform returns dataframes when transformers output them #20110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
thomasjpfan
wants to merge
9
commits into
scikit-learn:main
from
thomasjpfan:column_transformer_pandas_out
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
696fe53
ENH ColumnTransformer.transform returns dataframes when transformers …
thomasjpfan 0c69145
DOC Adds whats new with PR number
thomasjpfan 1334bcb
CLN Move pandas till later
thomasjpfan c37ddb7
DOC Adds docstring
thomasjpfan 59ad232
DOC Adds docstring to _hstack_np
thomasjpfan 24dcc0c
Merge remote-tracking branch 'upstream/main' into column_transformer_…
thomasjpfan d6f7a1e
TST Fixes test
thomasjpfan ef5e5e3
Merge remote-tracking branch 'upstream/main' into column_transformer_…
thomasjpfan 6513755
TST Adds test for sparse output
thomasjpfan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be a purist, sparse is not really
np
but coming fromscipy
:)I am wondering if we should have 2 functions here. I would prefer to have an if/else statement in the
_hstack
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
_safe_indexing
we indeed have 3 functions:_array_indexing
,_pandas_indexing
, and_list_indexing
. We could indeed have something similar then.