DOC Update minimal versions in documentation. #20143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
May 27, 2021
|
Thanks @cmarmo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up of #20069
What does this implement/fix? Explain your changes.
Update minimal versions in readme and installation documentation.
Any other comments?
Minimal versions of pandas are inconsistent in
scikit-learn/README.rst
Line 36 in 3c72fe5
and
scikit-learn/sklearn/_min_dependencies.py
Line 30 in 3c72fe5
As checks pass right now with pandas >= 0.23.4 should I downgrade the doc or upgrade the minimal dependencies? Thanks!