Skip to content

CI Removes python 3.6 builds from wheel building #20184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 3, 2021
Merged

CI Removes python 3.6 builds from wheel building #20184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
813ad2a
CI Removes python 3.6 builds [cd build]
thomasjpfan Jun 1, 2021
e5ace97
DOC Update comments
thomasjpfan Jun 1, 2021
d26b016
MNT Uses slightly newer version of wheels [cd build]
thomasjpfan Jun 1, 2021
93e18ca
CI [cd build]
thomasjpfan Jun 1, 2021
947de7e
Merge remote-tracking branch 'upstream/main' into fix_wheel_building
thomasjpfan Jun 1, 2021
11eff5e
CI pin scipy for python 3.7 [cd build]
thomasjpfan Jun 1, 2021
ae2d4a8
CI Try pinning oldest-supported-numpy [cd build]
thomasjpfan Jun 1, 2021
a5f486c
CI Check versions used by pip wheel [cd build]
thomasjpfan Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
name: Check build trigger
run: bash build_tools/github/check_build_trigger.sh

# Build the wheels for Linux, Windows and macOS for Python 3.6 and newer
# Build the wheels for Linux, Windows and macOS for Python 3.7 and newer
build_wheels:
name: Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}-${{ matrix.manylinux_image }}
runs-on: ${{ matrix.os }}
Expand All @@ -48,7 +48,7 @@ jobs:
fail-fast: false
matrix:
os: [windows-latest, ubuntu-latest, macos-latest]
python: [36, 37, 38, 39]
python: [37, 38, 39]
bitness: [32, 64]
manylinux_image: [manylinux1, manylinux2010]
include:
Expand Down Expand Up @@ -102,6 +102,7 @@ jobs:
CIBW_TEST_REQUIRES: pytest pandas threadpoolctl
CIBW_TEST_COMMAND: bash {project}/build_tools/github/test_wheels.sh
CIBW_TEST_COMMAND_WINDOWS: bash {project}/build_tools/github/test_windows_wheels.sh ${{ matrix.python }} ${{ matrix.bitness }}
CIBW_BUILD_VERBOSITY: 1

run: bash build_tools/github/build_wheels.sh

Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ requires = [
# wheels on PyPI
#
# see: https://github.com/scipy/oldest-supported-numpy/blob/master/setup.cfg
"oldest-supported-numpy",
"oldest-supported-numpy; python_version!='3.7' or platform_machine=='aarch64' or platform_system=='AIX' or platform_python_implementation == 'PyPy'",

# Override oldest-supported-numpy setting because pandas 0.25.0 requires 1.14.6
"numpy==1.14.6; python_version=='3.7' and platform_machine!='aarch64' and platform_system!='AIX' and platform_python_implementation != 'PyPy'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking that this was the reason why we had numpy 1.14.5 set as the minimum version.


"scipy>=1.1.0",
]