-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
FIX Do not reset for non-fit in multiclass #20205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Do not reset for non-fit in multiclass #20205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I changed the validation scheme twice and copy pasted too quickly for the last version :/
Actually it seems to break something. Let's validate properly: |
This can create a new numpy array when X is a list and Thinking through the test such as |
On a related note, I have been seeing the CI failing which is related related to the issue when the inner estimator is not validating. In that case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but don't we need a dedicated non-regression test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved this PR without realizing that there were newly introduced broken tests :(
Thanks @thomasjpfan |
Follow up to #20193
CC @jeremiedbb @ogrisel @glemaitre