MNT Allow to only validate y in _validate_data #20227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Jun 9, 2021
glemaitre
approved these changes
Jun 9, 2021
|
it's also useful for #19692 |
thomasjpfan
reviewed
Jun 11, 2021
ogrisel
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
LGTM. I just pushed an improvement to be stricter with complex values not being accepted in y. I think this was an oversight.
It's technically a breaking change for subclasses of scikit-learn that rely on _validate_date but since this is private API, I think this is fine.
|
Merged! Thanks @jeremiedbb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to make meta-estimators delegate input validation to their underlying estimator. However some meta-estimators perform some transformation on y before passing it to their underlying estimator (e.g. OutputCodeClassifier). For those it's more convenient to allow _validate_data to only perform the "y part" of check_X_y.
I think it's ok to have such a limited validation on y (column_or_1d + assert_all_finite) because we only need the minimum to pass the required transformations and it will be eventually validated by the underlying estimator.