Skip to content

DOC add image denoising kPCA example #20248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 29, 2021
Merged

DOC add image denoising kPCA example #20248

merged 16 commits into from
Jun 29, 2021

Conversation

glemaitre
Copy link
Member

Follow-up of #19945

Add example of kernel PCA to denoise data as an application.

@ogrisel
Copy link
Member

ogrisel commented Jun 11, 2021

Even if both PCA and kernel PCA have the same MSE, a qualitative analysis will favor the output of the kernel PCA.

I wouldn't be so sure :) It seems that the kPCA reconstructions can be biased into changing 6s into 1s blured with a 6s for instance. I assumed you already tweaked the params a lot and this is the best you could get?

ogrisel
ogrisel approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me although I find the setup a bit artificial as explained in the following:

@ogrisel
Copy link
Member

ogrisel commented Jun 15, 2021

Thanks!

jjerphan
jjerphan reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice example to add.

Here is a quick proofread.

ogrisel and others added 4 commits June 18, 2021 19:10
@ogrisel
Update examples/applications/plot_digits_denoising.py
cc530b0
@ogrisel @jjerphan
Update examples/applications/plot_digits_denoising.py
e3ce9a5 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@ogrisel @jjerphan
Update examples/applications/plot_digits_denoising.py
9e4c373 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@ogrisel @jjerphan
Update examples/applications/plot_digits_denoising.py
8358bc2 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
jjerphan approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @glemaitre !

@ogrisel ogrisel merged commit 1eece2c into scikit-learn:main Jun 29, 2021
@ogrisel ogrisel mentioned this pull request Jun 29, 2021
Merged
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@glemaitre @ogrisel
@jjerphan @thomasjpfan @samronsin
DOC add image denoising kPCA example (scikit-learn#20248)
1f390d6 

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Documentation No Changelog Needed Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glemaitre @ogrisel @jjerphan @thomasjpfan