Skip to content

DOC Ensures that LogisticRegressionCV passes numpydoc validation #20376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 28, 2021
Merged

DOC Ensures that LogisticRegressionCV passes numpydoc validation #20376

merged 5 commits into from
Jun 28, 2021

Conversation

gitdoluquita
Copy link
Contributor

#DataUmbrella sprint

Reference Issues/PRs

Adresses #20308

cc.: @lacouth pair programming partner

What does this implement/fix? Explain your changes.

Removing LogisticRegressionCV from DOCSTRING_IGNORE_LIST
Fixing numpydoc errors in LogisticRegressionCV class, fit method and score method.

@thomasjpfan thomasjpfan mentioned this pull request Jun 26, 2021
Closed
@gitdoluquita
Copy link
Contributor Author

Hi @glemaitre i solved the suggestions!
Let me if there's anything more to do.
Besides that, I have a doubt, maybe a begginer question but if you could help me, It would be great:
How do I know a line is too long? Is there a convention, besides running flake8 and black?

Thank you for the attention and the feedback!

@glemaitre
Copy link
Member

How do I know a line is too long? Is there a convention, besides running flake8 and black?

flake8 is indeed the linter that will tell you that the line is too long. So the limit is 79 characters.
We are transitioning to black for the code itself and currently, it is set to 88 characters but we have to vote if we keep the 80 characters limit or not :)

The best way to know about the limit when you edit the code is to have a vertical ruler on your IDE.

@glemaitre glemaitre merged commit 209b096 into scikit-learn:main Jun 28, 2021
@glemaitre
Copy link
Member

Merging. Looks good.

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@gitdoluquita @glemaitre @samronsin
DOC Ensures that LogisticRegressionCV passes numpydoc validation (sci…
8341014 
…kit-learn#20376)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

Assignees
No one assigned
Labels
Documentation module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitdoluquita @glemaitre