Skip to content

DOC Ensures that TfidfTransformer passes numpydoc validation #20379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2021
Merged

DOC Ensures that TfidfTransformer passes numpydoc validation #20379

merged 6 commits into from
Jun 26, 2021
+41 −15

Conversation

tomasmoreyra
Copy link
Contributor

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures TfidfTransformer is compatible with numpydoc.

  • Remove TfidfTransformer from DOCSTRING_IGNORE_LIST.
  • Verify all tests passing.

Any other comments?

Thanks #DataUmbrellla
cc: @jmloyola

tomasmoreyra and others added 2 commits June 26, 2021 15:34
@tomasmoreyra @glemaitre
Update sklearn/feature_extraction/text.py
1e6f8a7 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@tomasmoreyra @glemaitre
Update sklearn/feature_extraction/text.py
54e1fa3 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
glemaitre reviewed Jun 26, 2021
View reviewed changes
tomasmoreyra and others added 2 commits June 26, 2021 15:42
@tomasmoreyra @glemaitre
Update sklearn/feature_extraction/text.py
cfa95b4 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@tomasmoreyra @glemaitre
Update sklearn/feature_extraction/text.py
4cffd66 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@thomasjpfan thomasjpfan mentioned this pull request Jun 26, 2021
Closed
@glemaitre glemaitre merged commit 9682692 into scikit-learn:main Jun 26, 2021
@glemaitre
Copy link
Member

All good. Thanks @tomasmoreyra

@reshamas
Copy link
Member

updating with correct spelling: #DataUmbrella

@tomasmoreyra tomasmoreyra deleted the fix_numpydoc_tfidftransformer branch June 27, 2021 19:03
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@tomasmoreyra @glemaitre @samronsin
DOC Ensures that TfidfTransformer passes numpydoc validation (scikit-…
acacb9d 
…learn#20379)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

Assignees
No one assigned
Labels
Documentation module:feature_extraction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasmoreyra @glemaitre @reshamas