Skip to content

DOC Ensures that BayesianRidge passes numpydoc validation #20389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

pibieta
Copy link
Contributor

@pibieta pibieta commented Jun 26, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

Fixes numpydoc validation errors in BayesianRidge, namely:

  • Missing See Also descriptions.
  • Added periods.
  • Capital letter at the beginning of descriptions.

Any other comments?

#DataUmbrella sprint
cc: @pibieta @g4brielvs

pibieta added 2 commits June 26, 2021 16:48
…nto numpydoc_val_BayesianRidge

Fixed the branch inconsitencies with main branch
@pibieta
Copy link
Contributor Author

pibieta commented Jun 26, 2021

It seems I need an approval for github to run the test on 2 worlkflows. Can you help with that @glemaitre ?

@glemaitre
Copy link
Member

LGTM. Good to be merged. I just solved the conflict that comes from the previous changes in main.

@glemaitre glemaitre merged commit 089e567 into scikit-learn:main Jun 28, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…rn#20389)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants