Skip to content

DOC ensures SparsePCA docstring passes numpydoc validation #20395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2021

Conversation

ijpulidos
Copy link
Contributor

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

Makes SparsePCA compatible with numpydoc style.

Any other comments?

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of change to improve the description of the estimators.

@reshamas
Copy link
Member

reshamas commented Jul 7, 2021

#DataUmbrella LATAM sprint

@glemaitre
Copy link
Member

I merged my suggestions. If the CIs turn green then we will be merging.

@glemaitre glemaitre self-requested a review July 13, 2021 09:59
@glemaitre glemaitre merged commit 67eb690 into scikit-learn:main Jul 13, 2021
@glemaitre
Copy link
Member

Thanks @ijpulidos

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…arn#20395)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants