Skip to content

DOC Ensures that AdaBoostRegressor passes numpydoc validation #20400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 28, 2021

Conversation

gitdoluquita
Copy link
Contributor

#DataUmbrella sprint

Reference Issues/PRs

Adresses #20308

cc.: @lacouth pair programming partner

Removing AdaBoostRegressor from DOCSTRING_IGNORE_LIST

Fixing numpydoc errors in AdaBoostRegressor class, fit and score methods.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitdoluquita . Two minor comments otherwise LGTM.

@gitdoluquita
Copy link
Contributor Author

Thank you so much for the feedback @rth .
Solved the suggestions.
Let me know if anything more is needed.

@glemaitre
Copy link
Member

I merge my small suggestion at the same time than solving the conflicts. Let's wait for the CIs to complete

@glemaitre glemaitre merged commit f443f08 into scikit-learn:main Jun 28, 2021
@glemaitre
Copy link
Member

Thanks @gitdoluquita

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…-learn#20400)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants