DOC Ensures that Perceptron passes numpydoc validation #20404
Merged
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linting failed with, |
|
Updating with correct spelling: #DataUmbrella sprint |
ogrisel
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
LGTM besides the following fix.
Thanks @g4brielvs for the contribution. Next time you work on a PR, I suggest you create a dedicated branch instead of using main to be able to work concurrently on several PR and making it easy to fetch the main branch locally to reflect the ever changing state of the main branch of the official scikit-learn repo.
glemaitre
reviewed
Jun 28, 2021
|
@ogrisel Thank you for reviewing my PR! Apologies for my oversight. I created separate branches for my other PRs, but I made a mistake here. |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
ogrisel
reviewed
Jun 29, 2021
|
Thanks @g4brielvs! |
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…20404) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR ensures
Perceptronis compatible with numpydocdPerceptronfromDOCSTRING_IGNORE_LISTAny other comments?
Thanks #DataUmbrella