-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Ensures that VotingRegressor passes numpydoc validation #20450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove VotingRegressor
from the list of estimator located in maint_tools/test_docstring.py
Hi, thanks for reviewing. At first I removed it but since I did not know how to solve 2 failed I returned the change. One of the errors is:
|
Around line 121, you need to add a docstring for the
|
A thousand thanks. I added this text in 'named_estimators': """Object allows access any fitted sub-estimators by name."""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge main
into your branch. It will solve the failure in the CI.
I added a suggestion to add the returned type for one of the property.
Thanks. Merged! |
@Anavelyz To fix the issue with |
About this comment @thomasjpfan, where do I find a guide to do it correctly? |
For your case:
|
Ready! |
|
Something went wrong with the merge, would it be okay if I try to fix it for you? |
Yes, it's okay. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reference Issues/PRs
References Addresses #20308
What does this implement/fix? Explain your changes.
Updated parameters and returned values descriptions.
Any other comments?
#DataUmbrella Sprint
cc: (pair programming partner) @marielaraj