-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
ENH Uses _openmp_effective_n_threads to get the number of threads in HistGradientBoosting* #20477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2d66bc6
52f60c2
c392533
6313149
bec6f51
645cb9b
569bca6
1feb57f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -262,6 +262,13 @@ Changelog | |
:mod:`sklearn.ensemble` | ||
....................... | ||
|
||
- |Enhancement| :class:`~sklearn.ensemble.HistGradientBoostingClassifier` and | ||
:class:`~sklearn.ensemble.HistGradientBoostingRegressor` take cgroups quotas | ||
into account when deciding the number of threads used by OpenMP. This | ||
avoids performance problems caused by over-subscription when using those | ||
classes in a docker container for instance. :pr:`20477` | ||
Comment on lines
+268
to
+269
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is unrelated to docker, isn't it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, this only affects linux machines right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This will affect most machines because: the docker deamon needs a Linux kernel (to use cgroups and other features of it); this kernel generally is the host's OS's, or a virtual machine's running Linux. I think Docker started developing support for Windows-native images, but this is rather niche. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My comment about linux was dissociated from the one about docker. Basically, we should probably clarify that this change does not affect Windows or OSX users. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that it still affect Windows or OSX users because a Linux VM has to be used for Docker in those cases. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not talking about docker. I am saying that as far as I understand, this entry will not affect users using scikit-learn on Windows or OSX. |
||
by `Thomas Fan`_. | ||
|
||
- |Fix| Do not allow to compute out-of-bag (OOB) score in | ||
:class:`ensemble.RandomForestClassifier` and | ||
:class:`ensemble.ExtraTreesClassifier` with multiclass-multioutput target | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a link to https://en.wikipedia.org/wiki/Cgroups for further context. I'm not sure we can expect readers to know what cgroups is