Skip to content

ENH RFE passes metadata to the underlying fit and score methods #20491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

ENH RFE passes metadata to the underlying fit and score methods #20491

wants to merge 4 commits into from

Conversation

adrinjalali
Copy link
Member

During #20350 I realized RFE doesn't accept metadata (e.g sample_weight) to be passed to the underlying estimator. This PR fixes that part, the rest need to stay in the other PR.

cc @jnothman @thomasjpfan

@adrinjalali adrinjalali added this to the 1.0 milestone Jul 9, 2021
@thomasjpfan
Copy link
Member

thomasjpfan commented Jul 10, 2021 •
edited
Loading

I think the most recent active PR that resolves this is #20380

@adrinjalali
Copy link
Member Author

Ok, closing in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:feature_selection
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinjalali @thomasjpfan