Skip to content

DOC Ensures that CCA passes numpydoc validation #20504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 20, 2021

Conversation

napoles-uach
Copy link
Contributor

Reference Issues/PRs

Addresses #20308

Data Umbrella sprint

What does this implement/fix? Explain your changes.

Errors in sklearn/cross_decomposition/_pls.py for CCA Class, e. g. GL07, PR08, SA04, RT01, RT04, RT05 among others.

Any other comments?

@reshamas
Copy link
Member

#DataUmbrella LATAM sprint

@jmloyola
Copy link
Member

jmloyola commented Jul 13, 2021

It seems that there is another error with linting, but this time in another file (that you didn't modify).
I think that if you merge upstream/main into your branch to get the last changes to sklearn/multioutput.py the failing test will pass.

napoles-uach and others added 3 commits July 13, 2021 13:21
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
napoles-uach and others added 2 commits July 15, 2021 19:53
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
Copy link
Member

As mentioned in the original issue, item 3. (#20308), you need to remove the class from the DOCSTRING_IGNORE_LIST list

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add the flag "Request changes" to tag that the PR has been reviewed.

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@napoles-uach
Copy link
Contributor Author

As mentioned in the original issue, item 3. (#20308), you need to remove the class from the DOCSTRING_IGNORE_LIST list

I did that from the beginning, I would double check that it was removed. Thanks!!

@napoles-uach
Copy link
Contributor Author

As mentioned in the original issue, item 3. (#20308), you need to remove the class from the DOCSTRING_IGNORE_LIST list

I did that from the beginning, I would double check that it was removed. Thanks!!

Removed CCA from the DOCSTRING_IGNORE_LIST list 👍

@napoles-uach napoles-uach requested a review from glemaitre July 20, 2021 16:46
@glemaitre glemaitre self-assigned this Jul 20, 2021
@glemaitre
Copy link
Member

@napoles-uach What I needed was this change: 73fd5f5

I am not sure but it was not in your history. Maybe you did not commit or push your changes. Locally, the tests are passing so it should be OK and I will merge when all CIs will be green.

@napoles-uach
Copy link
Contributor Author

@napoles-uach What I needed was this change: 73fd5f5

I am not sure but it was not in your history. Maybe you did not commit or push your changes. Locally, the tests are passing so it should be OK and I will merge when all CIs will be green.

OK 🤞

@glemaitre
Copy link
Member

Merging. Looks good. Thanks @napoles-uach

@glemaitre glemaitre merged commit 462cf1b into scikit-learn:main Jul 20, 2021
@napoles-uach
Copy link
Contributor Author

Merging. Looks good. Thanks @napoles-uach

Thanks a lot @glemaitre 🙏

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants