Skip to content

DOC Ensures that GraphicalLasso passes numpydoc validation #20527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

genvalen
Copy link
Contributor

@genvalen genvalen commented Jul 14, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

Any other comments?

Edit: I shortened summaries of some methods in _empirical_covariance.py. Maybe there is better phrasing that helps keeps more information?

@genvalen genvalen marked this pull request as ready for review July 14, 2021 03:21
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change that should fit on either the current line or the next

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@genvalen genvalen requested a review from glemaitre July 15, 2021 15:01
@glemaitre glemaitre merged commit cd8201b into scikit-learn:main Jul 15, 2021
@glemaitre
Copy link
Member

Thanks @genvalen

@genvalen genvalen deleted the GraphicalLasso branch July 17, 2021 01:17
twicky99 added a commit to twicky99/scikit-learn that referenced this pull request Jul 18, 2021
DOC Ensures that GraphicalLasso passes numpydoc validation (scikit-learn#20527)
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…arn#20527)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants