Skip to content

DOC fix hyperlink for permutation test example #20697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2021

Conversation

glemaitre
Copy link
Member

I encountered the error while working on: #20552

We indeed move the example from feature_selection to model_selection. We forgot to change the hyperlink in the documentation and the warning was not raised by sphinx apparently.

@glemaitre
Copy link
Member Author

glemaitre commented Aug 6, 2021

@thomasjpfan It is weird. Is there a bad interaction between sphinx and sphinx-gallery.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the reference. We changed the name when we moved the file.

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@glemaitre
Copy link
Member Author

Arfff. Of course 🙃

@glemaitre
Copy link
Member Author

Thanks for spotting it 😝

@thomasjpfan thomasjpfan merged commit 4b0d291 into scikit-learn:main Aug 7, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants