Skip to content

ENH Adds feature_names_in_ to sklearn.semi_supervised #20788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2021
Merged

ENH Adds feature_names_in_ to sklearn.semi_supervised #20788

merged 5 commits into from
Aug 26, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Aug 20, 2021

Continues #18010

@ogrisel ogrisel requested a review from thomasjpfan August 20, 2021 15:56
@ogrisel
Copy link
Member Author

ogrisel commented Aug 20, 2021

It's not really possible to blindly delegate to the underlying base estimator because of the complex resampling code in fit. I therefore decided to always validate at the meta-estimator level and avoid redundant expensive finite checks using sklearn.config_context.

thomasjpfan
thomasjpfan reviewed Aug 20, 2021
View reviewed changes
thomasjpfan
thomasjpfan reviewed Aug 20, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow up PR!

@ogrisel @thomasjpfan
Apply suggestions from code review
e65759a 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
thomasjpfan approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lorentzenchr
lorentzenchr approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr lorentzenchr merged commit 5c0f3a6 into scikit-learn:main Aug 26, 2021
@ogrisel ogrisel deleted the column-name-consistency-semi_supervised branch August 26, 2021 07:34
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@ogrisel @samronsin
ENH Adds feature_names_in_ to sklearn.semi_supervised (scikit-learn#2…
812e637 
…0788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:semi_supervised No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @thomasjpfan @lorentzenchr