WIP support future extensiblity of grid search results #2079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid_search
andcross_validation.cross_val_score
into aCVScorer
, which I think should be private for this release until we're happy with its interface.This will make it much easier to support returning training times, etc. and additional input such as
sample_weight
.One of the main problem with dicts is that, unlike attributes of objects, the field names are difficult to deprecate (though if we needed to, we might consider subclassing dict).
It is part of the way towards a more extensible results interface from the
*SearchCV
estimators, as discussed at the ML, #1787, #1768, and to some extent #1034, #1020.Note: the
CVScorer
introduced in this PR is missing tests as yet.