Skip to content

[MRG] Add sparse input and sparse precomputed distances to sklearn/cluster/_optics.py #20802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[MRG] Add sparse input and sparse precomputed distances to sklearn/cluster/_optics.py #20802

wants to merge 19 commits into from

Conversation

yskybloue
Copy link
Contributor

Reference Issues/PRs

Fixes #11982 , Fixes #14736 (Continues work from stalled PR)

What does this implement/fix? Explain your changes.

Makes OPTICS.fit(self, X, y=None) support sparse matrix X of shape (n_samples,n_features) or (n_samples,n_samples) if precomputed distances.

@yskybloue yskybloue mentioned this pull request Aug 21, 2021
Closed
@cmarmo
Copy link
Contributor

cmarmo commented Nov 17, 2021

Hi @Clickedbigfoot, sorry your pull request went lost.
If you are still interested in this contribution, do you mind synchronizing with upstream?
This way documentation build and continuous integration will run again.
Thanks for your patience!

@JSchuerz
Copy link
Contributor

JSchuerz commented Mar 6, 2022 •
edited
Loading

Hi @cmarmo, if it is okay with you I will pick up this stalled PR and continue @Clickedbigfoot's work in order to fix #11982. I have merged his PR to (a new branch of) my fork and will continue working from there. When I'm done, which probably will take a while, I'll open a new PR. Do you agree? And how do I correctly cite his work?

@cmarmo
Copy link
Contributor

cmarmo commented Mar 7, 2022

I have merged his PR to (a new branch of) my fork and will continue working from there. When I'm done, which probably will take a while, I'll open a new PR. Do you agree? And how do I correctly cite his work?

Hi @JSchuerz, please go ahead! :)
You will find here and here some documentation about how to take over stalled pull requests.

@Micky774 Micky774 mentioned this pull request Mar 27, 2022
Merged
@cmarmo cmarmo removed the Stalled label Mar 30, 2022
@cmarmo cmarmo added Superseded PR has been replace by a newer PR and removed help wanted labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:cluster Superseded PR has been replace by a newer PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OPTICS should support sparse matrices and precomputed distances
4 participants
@yskybloue @cmarmo @JSchuerz @huntzhan