Skip to content

ENH Adds feature_names_in_ to ColumnTransformer #20839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2021
Merged

ENH Adds feature_names_in_ to ColumnTransformer #20839

merged 5 commits into from
Aug 26, 2021

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Aug 25, 2021 •
edited by lorentzenchr
Loading

Reference Issues/PRs

Follow up to #18010

What does this implement/fix? Explain your changes.

This PR adds feature_names_in_ to ColumnTransformer. ColumnTransformer deliberately does not require check for column name consistency. (see #19263)

@thomasjpfan thomasjpfan changed the title ENH Adds feature_names_in_ to compose ENH Adds feature_names_in_ to ColumnTransformer Aug 25, 2021
ogrisel
ogrisel approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ogrisel
ogrisel approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel
Copy link
Member

ogrisel commented Aug 25, 2021

Sorry for the double review, my wifi was not responsive and I thought the first review had failed :)

@ogrisel ogrisel mentioned this pull request Aug 25, 2021
Merged
@ogrisel ogrisel requested a review from lorentzenchr August 26, 2021 12:32
lorentzenchr
lorentzenchr approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nitpicks.

@thomasjpfan @lorentzenchr
Apply suggestions from code review
d13fc55 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@ogrisel ogrisel merged commit 7e7cdd6 into scikit-learn:main Aug 26, 2021
@zahs123
Copy link

zahs123 commented Sep 9, 2021 •
edited
Loading

hi how can i use this feature, i am using columntransfomer and unsure how to retrieve names

@thomasjpfan
Copy link
Member Author

This feature will be available with the release of 1.0. You can try it out by installing the RC:

pip install --pre scikit-learn

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@thomasjpfan @lorentzenchr @samronsin
ENH Adds feature_names_in_ to ColumnTransformer (scikit-learn#20839)
2551d16 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:compose No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @ogrisel @zahs123 @lorentzenchr