Skip to content

Check features_names_in_ in sklearn.multioutput #20847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2021
Merged

Check features_names_in_ in sklearn.multioutput #20847

merged 1 commit into from
Aug 26, 2021
+29 −1

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Aug 26, 2021

Reference Issues/PRs

Follow up to #18010

What does this implement/fix? Explain your changes.

  • Make ClassifierChain validate data in decision_function to be consistent with predict.
  • Multioutput meta estimators delegate to their first base estimator.

thomasjpfan
thomasjpfan approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lorentzenchr
lorentzenchr approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel ogrisel merged commit 270ac2e into scikit-learn:main Aug 26, 2021
@ogrisel ogrisel deleted the feature_names_in_-multioutput branch August 26, 2021 14:50
@ogrisel
Copy link
Member Author

ogrisel commented Aug 26, 2021

Merged!

@lorentzenchr
Copy link
Member

That was fast!

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@ogrisel @samronsin
Check features_names_in_ in sklearn.multioutput (scikit-learn#20847)
ea14f5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @lorentzenchr @thomasjpfan