Skip to content

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Aug 26, 2021

Reference Issues/PRs

Follow up to #18010

What does this implement/fix? Explain your changes.

Always delegate to the underlying best_estimator_ when defined. Depends on the value of refit in a complex way.

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a wish for unnitpicking.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment otherwise LGTM

@ogrisel ogrisel merged commit 2a6426f into scikit-learn:main Aug 26, 2021
@ogrisel ogrisel deleted the feature_names_in_-model_selection branch August 26, 2021 20:58
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants