ENH add `only_non_negative` parameter to `_check_sample_weight` by simonandras · Pull Request #20880 · scikit-learn/scikit-learn

Commits on Sep 1, 2021

Adding informative error message for the negative weight case (linear regression)
simonandras
committed
The negativity check is now in _check_sample_weight which can be turned on with the only_positive bool parameter (beckward compatible). For the check the alredy written check_non_negative is used.
simonandras
committed
Adding parameter documentation to the changed _check_sample_weight and rename the only_positive parameter to only_non_negative, because zeros are accepted.
simonandras
committed

Commits on Sep 2, 2021

Commits on Sep 3, 2021

Added entry to the changelog (sklearn.utils). Also corrected 2 typo in the changelog.
simonandras
committed

Commits on Sep 6, 2021

Merge branch 'main' into my-new-branch
simonandras
authored

Commits on Sep 7, 2021

Commits on Sep 8, 2021

move whats new version
glemaitre
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ENH add `only_non_negative` parameter to `_check_sample_weight`#20880

ENH add `only_non_negative` parameter to `_check_sample_weight`#20880
glemaitre merged 25 commits intoscikit-learn:mainfrom
simonandras:my-new-branch

Commits on Sep 1, 2021

Adding informative error message for the negative weight case (linear regression)

The negativity check is now in _check_sample_weight which can be turned on with the only_positive bool parameter (beckward compatible). For the check the alredy written check_non_negative is used.

Adding parameter documentation to the changed _check_sample_weight and rename the only_positive parameter to only_non_negative, because zeros are accepted.

Commits on Sep 2, 2021

Making some lines shorter than 88 char to pass tests

Make one line documentation in two lines to pass test (it was too long)

Delete whitespace in blank line

Add a dot to end of sentence (in modified function documentation)

formatting with black .

Update sklearn/utils/validation.py

Update sklearn/linear_model/_base.py

Update sklearn/utils/validation.py

Merge branch 'scikit-learn:main' into my-new-branch

Merge branch 'main' of https://github.com/simonandras/scikit-learn into my-new-branch

Merge branch 'my-new-branch' of https://github.com/simonandras/scikit-learn into my-new-branch

Solve the previous problems

reformatting with black .

In the documentation of _check_sample_weight changing the 3 space indents to 4 space indents

Adding test to test_validation.py to test the negative weight error in the _check_sample_weigth function

black .

In LinearRegression in fit method in _check_sample_weight function call make the parameter order like in the function definition

Commits on Sep 3, 2021

Added entry to the changelog (sklearn.utils). Also corrected 2 typo in the changelog.

Commits on Sep 6, 2021

Merge branch 'main' into my-new-branch

Commits on Sep 7, 2021

Merge branch 'main' into my-new-branch

Merge branch 'scikit-learn:main' into my-new-branch

Commits on Sep 8, 2021

move whats new version

Uh oh!

ENH add `only_non_negative` parameter to `_check_sample_weight`#20880glemaitre merged 25 commits intoscikit-learn:mainscikit-learn/scikit-learn:mainfrom simonandras:my-new-branchsimonandras/scikit-learn:my-new-branchCopy head branch name to clipboard

Commits

Commits on Sep 1, 2021

Commits on Sep 2, 2021

Commits on Sep 3, 2021

Commits on Sep 6, 2021

Commits on Sep 7, 2021

Commits on Sep 8, 2021

ENH add `only_non_negative` parameter to `_check_sample_weight`#20880
glemaitre merged 25 commits intoscikit-learn:mainfrom
simonandras:my-new-branch