Skip to content

Make the check changelog message more explicit #20911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

Make the check changelog message more explicit #20911

merged 1 commit into from
Sep 2, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Sep 1, 2021

To be friendlier to our perplexed contributors :)

thomasjpfan
thomasjpfan approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is an improvement to the contributor experience.

@TomDLT TomDLT merged commit d7cecb3 into scikit-learn:main Sep 2, 2021
@ogrisel ogrisel deleted the improve-changelog-check-message branch September 2, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @thomasjpfan @TomDLT