DOC Replace the phrase "where n_samples in the number" with "where n_samples is the number"
#20914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inside of a docstring.
…s` in' rather than 'where `n_samples` is'.
…nto edit_typos
…nto edit_typos
TomDLT
approved these changes
Sep 2, 2021
…nto edit_typos
Yup! |
|
Thanks @genvalen merging |
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 10, 2021
…_new add backticks (scikit-learn#20914), deprecate **params in fit (scikit-learn#20843), add feature_names_in_ (scikit-learn#20787)
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 10, 2021
…_new add backticks (scikit-learn#20914), deprecate **params in fit (scikit-learn#20843), add feature_names_in_ (scikit-learn#20787) uncompromisingly reformat plot_oneclass_vs_svdd with black
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
May 15, 2022
…_new add backticks (scikit-learn#20914), deprecate **params in fit (scikit-learn#20843), add feature_names_in_ (scikit-learn#20787) uncompromisingly reformat plot_oneclass_vs_svdd with black
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 14, 2022
…_new add backticks (scikit-learn#20914), deprecate **params in fit (scikit-learn#20843), add feature_names_in_ (scikit-learn#20787) uncompromisingly reformat plot_oneclass_vs_svdd with black
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 29, 2022
…_new add backticks (scikit-learn#20914), deprecate **params in fit (scikit-learn#20843), add feature_names_in_ (scikit-learn#20787) uncompromisingly reformat plot_oneclass_vs_svdd with black
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Sep 5, 2022
…_new add backticks (scikit-learn#20914), deprecate **params in fit (scikit-learn#20843), add feature_names_in_ (scikit-learn#20787) uncompromisingly reformat plot_oneclass_vs_svdd with black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #20822
What does this implement/fix? Explain your changes.
Previously, in PR #20822, I edited a small typo in the phrase "where n_samples in the number" by updating it to "where n_samples is the number".
This PR:
git grep 'where `n_samples` in'.n_samples(alson_features,n_components) in a docstring that don't have them:n_samples -> `n_samples`.Any other comments?
I believe this catches all last cases of the typo. Please let me know if anything can be added or changed.