BUG Corrects tag in TfidfTransformer #20919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have an issue with some int32/int64 casting in the 32 bits system. Nice PR. |
|
Thanks. |
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Sep 3, 2021
adrinjalali
pushed a commit
that referenced
this pull request
Sep 6, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the tag in
TfidfTransformerand adds a new common test to check that the tags are the correct dtype.This is kind of related to #20804, where
X_typesis overriding the default["2darray"]which skips most of the common test.