-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT bumb version number to 1.1 #20945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ | |
Version 1.0.0 | ||
============= | ||
|
||
**In Development** | ||
**September 2021** | ||
|
||
|
||
.. include:: changelog_legend.inc | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
.. include:: _contributors.rst | ||
|
||
.. currentmodule:: sklearn | ||
|
||
.. _changes_1_1: | ||
|
||
Version 1.1.0 | ||
============= | ||
|
||
**In Development** | ||
|
||
|
||
.. include:: changelog_legend.inc | ||
|
||
Minimal dependencies | ||
-------------------- | ||
|
||
Version 1.1.0 of scikit-learn requires python 3.7+, numpy 1.14.6+ and | ||
scipy 1.1.0+. Optional minimal dependency is matplotlib 2.2.2+. | ||
|
||
Put the changes in their relevant module. | ||
|
||
Changed models | ||
-------------- | ||
|
||
|
||
Changelog | ||
--------- | ||
|
||
.. | ||
Entries should be grouped by module (in alphabetic order) and prefixed with | ||
one of the labels: |MajorFeature|, |Feature|, |Efficiency|, |Enhancement|, | ||
|Fix| or |API| (see whats_new.rst for descriptions). | ||
Entries should be ordered by those labels (e.g. |Fix| after |Efficiency|). | ||
Changes not specific to a module should be listed under *Multiple Modules* | ||
or *Miscellaneous*. | ||
Entries should end with: | ||
:pr:`123456` by :user:`Joe Bloggs <joeongithub>`. | ||
where 123456 is the *pull request* number, not the issue number. | ||
|
||
|
||
:mod:`sklearn.decomposition` | ||
............................ | ||
|
||
|
||
Code and Documentation Contributors | ||
----------------------------------- | ||
|
||
Thanks to everyone who has contributed to the maintenance and improvement of | ||
the project since version 1.0, including: | ||
|
||
TODO: update at the time of the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we only state matplotlib or pandas and co. to be able to run the examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically all those are optional dependencies, so it's unclear where we put the limit. I'm fine with the current version and also fine with adding pandas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought about that, but as far as it goes for the library, and not the examples, we only consume pandas, whereas we actually use matplotlib. So I figured I'm happy with having matplotlib here but not pandas. Once we give pandas as output, then we'd need to have it here.