Skip to content

bump to 1.0.0.rc1 #20947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Conversation

adrinjalali
Copy link
Member

bumping the release to 1.0.0.rc1

@adrinjalali adrinjalali added this to the 1.0 milestone Sep 5, 2021
@glemaitre
Copy link
Member

Do you want to separate it from #20945?

@adrinjalali
Copy link
Member Author

This is to the release branch, #20945 is to main, they need to be separate, or am I missing something @glemaitre 😁

@glemaitre
Copy link
Member

Whoops, I did not see the branch of course :)

@adrinjalali
Copy link
Member Author

So this passes all the wheel builds, but I don't know where to get the wheels generated by travis

@glemaitre
Copy link
Member

Instead of Travis, we should merge #20711 for the ARM wheels.

@glemaitre
Copy link
Member

But this should be the part to check where it is in Travis: https://github.com/scikit-learn/scikit-learn/blob/main/build_tools/github/check_wheels.py#L23-L30

@alfaro96
Copy link
Member

alfaro96 commented Sep 6, 2021

So this passes all the wheel builds, but I don't know where to get the wheels generated by travis

The wheels generated by Travis are uploaded to Anaconda cloud weekly for the main branch or when a pull request is merged into a branch with the commit message marker [cd build].

AFAIK, I think that we cannot get the Travis wheels for a particular PR.

CC @thomasjpfan or @ogrisel.

@ogrisel
Copy link
Member

ogrisel commented Sep 6, 2021

Yes we can only fetch the wheels generated by the merge commit to the 1.0.X branch as the anaconda.org secret upload tokens are not available on commit triggered by a PR from a fork for security reasons.

But if the [cd build] jobs passes on the PR, they are very likely to also pass on the merge commit it-self.

@ogrisel
Copy link
Member

ogrisel commented Sep 6, 2021

BTW, I am currently working on finalizing the #20711 to get a working staging area upload step fro the linux ARM wheels on circle ci.

@adrinjalali
Copy link
Member Author

I rather not wait for @20711 for the release. I'll try to get an RC out today, even if it doesn't include ARM wheels (hopefully it will, from travis)

@adrinjalali adrinjalali merged commit c21491f into scikit-learn:1.0.X Sep 7, 2021
@adrinjalali adrinjalali deleted the release1version branch September 7, 2021 10:05
@ogrisel
Copy link
Member

ogrisel commented Sep 7, 2021

I found a way to make the travis build work faster and without failure on main: #20958.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants