BUG Fixes FunctionTransformer validation in inverse_transform #20961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to add in the documentation, the fitted attribute. However, it is only set if |
|
Oh no, I see that actually, we don't want it to exist then. So we only need to add it to the documentation. |
|
@glemaitre merge? |
|
Tagging for #20965 if it gets in. If it does not get it, I think this PR can also be considered a 1.0.1 bug fix |
|
Looks good. |
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Sep 10, 2021
adrinjalali
pushed a commit
that referenced
this pull request
Sep 14, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
FunctionTransformerwhereinverse_transformstoresn_features_in_based on the input toinverse_transform.