Skip to content

CLN Removes old sphinx theme #20962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Sep 7, 2021

Closes #20922

This PR removes the old site template. This closes #20922 by removing the old jquery from the repo.

For Nostalgia 😄

Screen Shot 2021-09-06 at 10 15 10 PM

@thomasjpfan thomasjpfan changed the title CLN Removes old site template CLN Removes old sphinx theme Sep 7, 2021
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel
Copy link
Member

ogrisel commented Sep 7, 2021

I pushed a [doc build] commit just to make sure it does not break the full circle ci doc build.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full html rendering did not fail and looks good to me.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I spoke too quickly, there are broken image links, for instance some logos are used in this page:

https://151386-843222-gh.circle-artifacts.com/0/doc/about.html#funding

@thomasjpfan thomasjpfan force-pushed the remove_old_site_template branch from 34624c8 to 821b631 Compare September 7, 2021 21:56
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did another quick visual check and did not see any other problems. LGTM. Thanks @thomasjpfan!

@ogrisel ogrisel merged commit e2aa522 into scikit-learn:main Sep 8, 2021
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre pushed a commit that referenced this pull request Oct 25, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaged jQuery version is vulnerable
3 participants