FIX Fixes test for checking gitignore and Cython templates #20997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's weird that our CI did not fail though... |
thomasjpfan
reviewed
Sep 12, 2021
There was a problem hiding this comment.
Thank you for the PR @gaborkertesz !
This looks good. Small comment on implementation.
Comment on lines
13
to
16
| ignored_files = open(gitignore_file, "r").readlines() | ||
| ignored_files = list(map(lambda line: line.strip("\n"), ignored_files)) | ||
| ignored_files = list( | ||
| map(lambda line: pathlib.Path(line.strip("\n")), ignored_files) | ||
| ) |
There was a problem hiding this comment.
Since we are now comparing paths, may we include the following update to fully use the pathlib api?
ignored_files = gitignore_file.read_text().split("\n")
ignored_files = [pathlib.Path(line) for line in ignored_files]There was a problem hiding this comment.
Great finding, thanks, applied!
Converting to string removed the windows compatible path.
|
In the title the "gitnore" is a typo of "gitignore" or it's an abbreviation @thomasjpfan? |
Good catch! (It was a typo) |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting to string removed the windows compatible path.
Reference Issues/PRs
Fixes #20996 20996
What does this implement/fix? Explain your changes.
Removing string conversion and comparing objects by assert.
Any other comments?