Skip to content

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Sep 10, 2021

Reference Issues/PRs

Fixes #20212

What does this implement/fix? Explain your changes.

The --no-build-isolation means that NumPy and SciPy needs to be installed before scikit-learn can be built. This PR adds this two dependencies to the instructions.

@ogrisel ogrisel merged commit 0cb7def into scikit-learn:main Sep 10, 2021
@NicolasHug
Copy link
Member

Thanks for the PR @thomasjpfan

Those dependencies are automatically installed by pip if they were missing when building scikit-learn from source.

This line still exists and it's incorrect since numpy and scipy aren't installed automatically

Also, do you think it would be possible to have a check that makes sure our instructions are always correct? We seem to break them fairly often and it becomes a significant issue for contributing (see #20212 (comment) and the follow-ups)

@thomasjpfan
Copy link
Member Author

Also, do you think it would be possible to have a check that makes sure our instructions are always correct? We seem to break them fairly often and it becomes a significant issue for contributing (see #20212 (comment) and the follow-ups)

It is possible. We can use literalinclude to include sections of a build script on the CI. Specifically, start-after and end-before options allow us to choose sections of the build script to include in the install docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build dependencies in developer guide seem incorrect
3 participants