Skip to content

ENH add pos_label in calibration tools #21032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 2, 2021
Merged

ENH add pos_label in calibration tools #21032

merged 8 commits into from
Oct 2, 2021

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Sep 13, 2021 •
edited
Loading

closes #21029

calibration_curve is missing the parameter pos_label. It should be consistent with the other *_curve functions.
In addition, this parameter should be used in the calibration estimator and display.

TODO:

  • add pos_label in calibration_curve
  • add tests for str label and 0 class.

@glemaitre glemaitre mentioned this pull request Sep 14, 2021
Merged
ogrisel
ogrisel approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

glemaitre and others added 2 commits September 24, 2021 15:31
@glemaitre @ogrisel
Update sklearn/tests/test_calibration.py
55636db 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@glemaitre
Merge branch 'main' into is/21029
9f4ab8d
thomasjpfan
thomasjpfan reviewed Sep 25, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Mostly looks ready, I left a small comment regarding the error message.

thomasjpfan
thomasjpfan approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I did push to fix the merged conflict.

@thomasjpfan thomasjpfan merged commit d152b1e into scikit-learn:main Oct 2, 2021
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
Merged
10 tasks
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@glemaitre @ogrisel
@thomasjpfan @samronsin
ENH add pos_label in calibration tools (scikit-learn#21032)
1758ab3 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing a pos_label parameter in calibration_curve
3 participants
@glemaitre @ogrisel @thomasjpfan