TST enable tests K-means for MacOS #21052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in test_predict # With n_init > 1
# Due to randomness in the order in which chunks of data are processed when
# using more than one thread, there might be different rounding errors for
# the computation of the inertia between 2 runs. This might result in a
# different ranking of 2 inits, hence a different labeling, even if they
# give the same clustering. We only check the labels up to a permutation.This should have been fixed by #20200. Would you mind trying to replace |
jeremiedbb
reviewed
Sep 15, 2021
| @@ -804,8 +750,8 @@ def test_k_means_function(): | |||
| assert cluster_centers.shape == (n_clusters, n_features) | |||
| assert np.unique(labels).shape[0] == n_clusters | |||
|
|
|||
| # check that the labels assignment are perfect (up to a permutation) | |||
| assert_allclose(v_measure_score(true_labels, labels), 1.0) | |||
There was a problem hiding this comment.
For this one we don't expect the labels to match perfectly since the true labels are manually defined. We can only try to remove the v_measure_score when comparing 2 kmeans run that should be identical
ogrisel
approved these changes
Sep 15, 2021
|
It is green then I will merge. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
glemaitre
added a commit
that referenced
this pull request
Oct 25, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the tests are still failing in MacOS