Skip to content

DOC Typos found by codespell #21069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2021
Merged

DOC Typos found by codespell #21069

merged 5 commits into from
Sep 17, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 16, 2021 •
edited
Loading

Reference Issues/PRs

#21051

What does this implement/fix? Explain your changes.

A one-shot fix of typos currently found by codespell.

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Sep 16, 2021
Merged
ogrisel
ogrisel approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following typos should not be fixed as they are present in the original openml dataset columns spec.

Other than that, and assuming it fixes the problem. LGTM.

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the codespell_typos branch 3 times, most recently from 3e8f355 to 9777166 Compare September 16, 2021 16:12
lorentzenchr
lorentzenchr reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of those are from me 😊

DimitriPapadopoulos and others added 4 commits September 17, 2021 16:59
@DimitriPapadopoulos @lorentzenchr
Update doc/modules/outlier_detection.rst
9abb6f3 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@DimitriPapadopoulos @lorentzenchr
Update sklearn/cluster/_k_means_elkan.pyx
2cff74a 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@DimitriPapadopoulos @lorentzenchr
Update sklearn/cluster/_k_means_lloyd.pyx
ab37062 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@DimitriPapadopoulos @lorentzenchr
Update sklearn/cluster/_k_means_elkan.pyx
8aa4817 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@lorentzenchr lorentzenchr merged commit f71c031 into scikit-learn:main Sep 17, 2021
@lorentzenchr
Copy link
Member

@DimitriPapadopoulos Thank you for correcting those typos.

@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell_typos branch September 17, 2021 17:07
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Sep 20, 2021
@DimitriPapadopoulos @adrinjalali
DOC Typos found by codespell (scikit-learn#21069)
1b800b0
adrinjalali
adrinjalali reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr lorentzenchr mentioned this pull request Sep 22, 2021
Merged
adrinjalali pushed a commit that referenced this pull request Sep 23, 2021
@DimitriPapadopoulos @adrinjalali
DOC Typos found by codespell (#21069)
8f2d211
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@DimitriPapadopoulos @samronsin
DOC Typos found by codespell (scikit-learn#21069)
a375848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali left review comments

@lorentzenchr lorentzenchr lorentzenchr left review comments

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
cython Documentation No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DimitriPapadopoulos @lorentzenchr @ogrisel @adrinjalali